Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release leads rotation for Knative v1.15 #1590

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Jul 3, 2024

Part of knative/release PR: knative/release#315

/cc @ReToCode @skonto @Cali0707 @Leo6Leo
/cc @knative/technical-oversight-committee

Copy link

knative-prow bot commented Jul 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2024
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dprotaso
Copy link
Member

dprotaso commented Jul 3, 2024

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2024
@knative-prow knative-prow bot merged commit ea6a784 into knative:main Jul 3, 2024
6 checks passed
@dsimansk dsimansk deleted the pr/release-leads-1.15 branch July 3, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants